]> git.baikalelectronics.ru Git - kernel.git/commit
net: avoid overflow when rose /proc displays timer information.
authorFrancois Romieu <romieu@fr.zoreil.com>
Tue, 2 Aug 2022 15:07:42 +0000 (17:07 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 6 Aug 2022 02:00:02 +0000 (19:00 -0700)
commit86615e14b72fa5ed05d9fc59213d9e4411c993a6
tree8978c17dde437068157b2114802021ea5079f3aa
parent2ea5a1a95a86ce74f1f38a74b74aff13944d7b3b
net: avoid overflow when rose /proc displays timer information.

rose /proc code does not serialize timer accesses.

Initial report by Bernard F6BVP Pidoux exhibits overflow amounting
to 116 ticks on its HZ=250 system.

Full timer access serialization would imho be overkill as rose /proc
does not enforce consistency between displayed ROSE_STATE_XYZ and
timer values during changes of state.

The patch may also fix similar behavior in ax25 /proc, ax25 ioctl
and netrom /proc as they all exhibit the same timer serialization
policy. This point has not been reported though.

The sole remaining use of ax25_display_timer - ax25 rtt valuation -
may also perform marginally better but I have not analyzed it too
deeply.

Cc: Thomas DL9SAU Osterried <thomas@osterried.de>
Link: https://lore.kernel.org/all/d5e93cc7-a91f-13d3-49a1-b50c11f0f811@free.fr/
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Tested-by: Bernard Pidoux <f6bvp@free.fr>
Link: https://lore.kernel.org/r/Yuk9vq7t7VhmnOXu@electric-eye.fr.zoreil.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ax25/ax25_timer.c