]> git.baikalelectronics.ru Git - kernel.git/commit
tty: make FONTX ioctl use the tty pointer they were actually passed
authorLinus Torvalds <torvalds@linux-foundation.org>
Mon, 26 Oct 2020 20:15:23 +0000 (13:15 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 2 Nov 2020 22:49:17 +0000 (14:49 -0800)
commit853cb38dfa6d8c0ae6a436c149bb80a875149a69
treec381e25ec3c31ba296df929fdfcc72eb6fc3b004
parentaec58ec23324f78a3232b45a996efbc3fbf28361
tty: make FONTX ioctl use the tty pointer they were actually passed

Some of the font tty ioctl's always used the current foreground VC for
their operations.  Don't do that then.

This fixes a data race on fg_console.

Side note: both Michael Ellerman and Jiri Slaby point out that all these
ioctls are deprecated, and should probably have been removed long ago,
and everything seems to be using the KDFONTOP ioctl instead.

In fact, Michael points out that it looks like busybox's loadfont
program seems to have switched over to using KDFONTOP exactly _because_
of this bug (ahem.. 12 years ago ;-).

Reported-by: Minh Yuan <yuanmingbuaa@gmail.com>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Jiri Slaby <jirislaby@kernel.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/tty/vt/vt_ioctl.c