]> git.baikalelectronics.ru Git - kernel.git/commit
tty: n_gsm: fix resource allocation order in gsm_activate_mux()
authorDaniel Starke <daniel.starke@siemens.com>
Fri, 1 Jul 2022 12:23:32 +0000 (14:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:24:05 +0000 (14:24 +0200)
commit8484e2cc2d8ce8455131c30814f003cc7a49eab6
treef68f287def4af9133f1d49708b411e76723c52ba
parent4d43eba1fb3acff2efaf35bd3532a19dadd32ef7
tty: n_gsm: fix resource allocation order in gsm_activate_mux()

[ Upstream commit 9662669e9a62e533a4ab1aaa4e1a5b93252665e9 ]

Within gsm_activate_mux() all timers and locks are initiated before the
actual resource for the control channel is allocated. This can lead to race
conditions.

Allocate the control channel DLCI object first to avoid race conditions.

Fixes: 99551fa31543 ("tty: n_gsm line discipline")
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
Link: https://lore.kernel.org/r/20220701122332.2039-2-daniel.starke@siemens.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/n_gsm.c