]> git.baikalelectronics.ru Git - kernel.git/commit
blk-iocost: ioc_pd_free() shouldn't assume irq disabled
authorTejun Heo <tj@kernel.org>
Tue, 1 Sep 2020 18:52:31 +0000 (14:52 -0400)
committerJens Axboe <axboe@kernel.dk>
Tue, 1 Sep 2020 22:48:44 +0000 (16:48 -0600)
commit8453708f1b3e62f9706d329087acdd2b61dfce89
treed380ddce8bf1e1a8d2e043e1491ba3da588ef89f
parent3e441c5626638afc40eb2333b62c452e21fa5f3c
blk-iocost: ioc_pd_free() shouldn't assume irq disabled

ioc_pd_free() grabs irq-safe ioc->lock without ensuring that irq is disabled
when it can be called with irq disabled or enabled. This has a small chance
of causing A-A deadlocks and triggers lockdep splats. Use irqsave operations
instead.

Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 804998b28924 ("blkcg: implement blk-iocost")
Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-iocost.c