]> git.baikalelectronics.ru Git - kernel.git/commit
sh: intc: Avoid spurious sizeof-pointer-div warning
authorMichael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
Tue, 24 Jan 2023 21:48:16 +0000 (22:48 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Mar 2023 12:33:54 +0000 (13:33 +0100)
commit839c3c77dd779d87fb9a2225ff8dcbd007e924ad
treeff6ea23b98e28174d5a3f1da2d1dfbfbd6a7a5e7
parent9f54c8f3b737e8c0518bd7448b7de210345892df
sh: intc: Avoid spurious sizeof-pointer-div warning

[ Upstream commit 02f9bbfc8cc17774b3005db12d04d2e84e73bcea ]

GCC warns about the pattern sizeof(void*)/sizeof(void), as it looks like
the abuse of a pattern to calculate the array size. This pattern appears
in the unevaluated part of the ternary operator in _INTC_ARRAY if the
parameter is NULL.

The replacement uses an alternate approach to return 0 in case of NULL
which does not generate the pattern sizeof(void*)/sizeof(void), but still
emits the warning if _INTC_ARRAY is called with a nonarray parameter.

This patch is required for successful compilation with -Werror enabled.

The idea to use _Generic for type distinction is taken from Comment #7
in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108483 by Jakub Jelinek

Signed-off-by: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Link: https://lore.kernel.org/r/619fa552-c988-35e5-b1d7-fe256c46a272@mkarcher.dialup.fu-berlin.de
Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/linux/sh_intc.h