]> git.baikalelectronics.ru Git - kernel.git/commit
dm verity fec: fix misaligned RS roots IO
authorJaegeuk Kim <jaegeuk@google.com>
Wed, 14 Apr 2021 15:28:28 +0000 (08:28 -0700)
committerMike Snitzer <snitzer@redhat.com>
Wed, 14 Apr 2021 18:28:29 +0000 (14:28 -0400)
commit8347ae5898d2be7e07b0a28d144428958d1ce3f3
tree85e7c10725c382e9ba342690e457badff7268daa
parentee7c5a800b7712543c03f412a7611ba9000cd43f
dm verity fec: fix misaligned RS roots IO

commit fdf7bf5dcc7f ("dm verity: fix FEC for RS roots unaligned to
block size") introduced the possibility for misaligned roots IO
relative to the underlying device's logical block size. E.g. Android's
default RS roots=2 results in dm_bufio->block_size=1024, which causes
the following EIO if the logical block size of the device is 4096,
given v->data_dev_block_bits=12:

E sd 0    : 0:0:0: [sda] tag#30 request not aligned to the logical block size
E blk_update_request: I/O error, dev sda, sector 10368424 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0
E device-mapper: verity-fec: 254:8: FEC 9244672: parity read failed (block 18056): -5

Fix this by onlu using f->roots for dm_bufio blocksize IFF it is
aligned to v->data_dev_block_bits.

Fixes: fdf7bf5dcc7f ("dm verity: fix FEC for RS roots unaligned to block size")
Cc: stable@vger.kernel.org
Signed-off-by: Jaegeuk Kim <jaegeuk@google.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-verity-fec.c
drivers/md/dm-verity-fec.h