]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: topology: Fix using uninitialized pointer
authorJaska Uimonen <jaska.uimonen@linux.intel.com>
Wed, 19 May 2021 10:07:13 +0000 (13:07 +0300)
committerMark Brown <broonie@kernel.org>
Thu, 20 May 2021 16:57:28 +0000 (17:57 +0100)
commit831d88ac7f24f1cadc6482e031133142b6eb6d8d
treef58459bee23394ababd7e74d9b0aec17e8fdfae7
parent4a043a970034f3c3d04a3ccb4c66a40e5ff3a0cf
ASoC: topology: Fix using uninitialized pointer

The original patch changed kcontrol_type to a pointer. In some goto
cases the pointer is assigned into a struct member as uninitialized and
this will cause a runtime error with UBSan even if it isn't a real bug.
So initialize the pointer to NULL.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 1b5c1c6331e4 ("ASoC: topology: Add support for multiple kcontrol types to a widget")
Signed-off-by: Jaska Uimonen <jaska.uimonen@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20210519100713.879958-1-jaska.uimonen@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-topology.c