]> git.baikalelectronics.ru Git - kernel.git/commit
Merge branch 'vxlan-fix-default-fdb-entry-user-space-notify-ordering-race'
authorDavid S. Miller <davem@davemloft.net>
Sat, 7 Jul 2018 11:20:46 +0000 (20:20 +0900)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Jul 2018 11:20:46 +0000 (20:20 +0900)
commit81aefac9f9699001292d90c2a9ff8e9a835593a5
treef5b7e5aad97f87d4d5a429662ed29d8f13cc146b
parentd73f21513b4742cad81f7985b770b187360d055c
parent708d94b046f93bf11e27d00585202263ad0d1338
Merge branch 'vxlan-fix-default-fdb-entry-user-space-notify-ordering-race'

Roopa Prabhu says:

====================
vxlan: fix default fdb entry user-space notify ordering/race

Problem:
In vxlan_newlink, a default fdb entry is added before register_netdev.
The default fdb creation function notifies user-space of the
fdb entry on the vxlan device which user-space does not know about yet.
(RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex).

This series fixes the user-space netlink notification ordering issue
with the following changes:
- decouple fdb notify from fdb create.
- Move fdb notify after register_netdev.
- modify rtnl_configure_link to allow configuring a link early.
- Call rtnl_configure_link in vxlan newlink handler to notify
userspace about the newlink before fdb notify and
hence avoiding the user-space race.
====================

Fixes: a762d3d70d3e ("vxlan: add implicit fdb entry for default destination")
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>