]> git.baikalelectronics.ru Git - kernel.git/commit
net: Catch invalid index in XPS mapping
authorNick Child <nnac123@linux.ibm.com>
Tue, 21 Mar 2023 15:07:24 +0000 (10:07 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 May 2023 11:44:03 +0000 (12:44 +0100)
commit815afa62820044376e515d7d6eb64ea8e0a6876c
tree13e6e18eed5e9eacb2abfb6fd849b13628ebbb16
parenta9c8fdb8ebca462a1fa1d00c754c1419f563ec91
net: Catch invalid index in XPS mapping

[ Upstream commit 5dd0dfd55baec0742ba8f5625a0dd064aca7db16 ]

When setting the XPS value of a TX queue, warn the user once if the
index of the queue is greater than the number of allocated TX queues.

Previously, this scenario went uncaught. In the best case, it resulted
in unnecessary allocations. In the worst case, it resulted in
out-of-bounds memory references through calls to `netdev_get_tx_queue(
dev, index)`. Therefore, it is important to inform the user but not
worth returning an error and risk downing the netdevice.

Signed-off-by: Nick Child <nnac123@linux.ibm.com>
Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>
Link: https://lore.kernel.org/r/20230321150725.127229-1-nnac123@linux.ibm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/dev.c