]> git.baikalelectronics.ru Git - kernel.git/commit
io_uring: correct timeout req sequence when inserting a new entry
authorzhangyi (F) <yi.zhang@huawei.com>
Wed, 23 Oct 2019 07:10:09 +0000 (15:10 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 24 Oct 2019 04:09:56 +0000 (22:09 -0600)
commit810a1182386cf079ca4551c35731f981eca42141
tree7db113e60fe823f52bf4d743444f9f47898e81d7
parentcde01e449780e0d69df365495c52f1dcfdfbb2c8
io_uring: correct timeout req sequence when inserting a new entry

The sequence number of the timeout req (req->sequence) indicate the
expected completion request. Because of each timeout req consume a
sequence number, so the sequence of each timeout req on the timeout
list shouldn't be the same. But now, we may get the same number (also
incorrect) if we insert a new entry before the last one, such as submit
such two timeout reqs on a new ring instance below.

                    req->sequence
 req_1 (count = 2):       2
 req_2 (count = 1):       2

Then, if we submit a nop req, req_2 will still timeout even the nop req
finished. This patch fix this problem by adjust the sequence number of
each reordered reqs when inserting a new entry.

Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c