]> git.baikalelectronics.ru Git - kernel.git/commit
leds: fix multiple requests and releases of IRQ for GPIO LED Trigger
authorThadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Wed, 26 Aug 2009 21:29:31 +0000 (14:29 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 27 Aug 2009 03:06:53 +0000 (20:06 -0700)
commit80c3c8e91d678a213d0f072f7d331408de6517d1
tree713e481085d33d73a8cf43131317db6c4aa206aa
parent109978744ccfa6a7ac592497f53f87019fb593d9
leds: fix multiple requests and releases of IRQ for GPIO LED Trigger

When setting the same GPIO number, multiple IRQ shared requests will be
done without freing the previous request.  It will also try to free a
failed request or an already freed IRQ if 0 was written to the gpio file.

All these oops and leaks were fixed with the following solution: keep the
previous allocated GPIO (if any) still allocated in case the new request
fails.  The alternative solution would desallocate the previous allocated
GPIO and set gpio as 0.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Signed-off-by: Samuel R. C. Vale <srcvale@holoscopio.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/leds/ledtrig-gpio.c