]> git.baikalelectronics.ru Git - kernel.git/commit
be2net: Revert "make the RX_FILTER command asynchronous" commit
authorSathya Perla <sathya.perla@avagotech.com>
Thu, 3 Sep 2015 11:41:53 +0000 (07:41 -0400)
committerDavid S. Miller <davem@davemloft.net>
Sun, 6 Sep 2015 05:01:21 +0000 (22:01 -0700)
commit8037b2d5c4cd21dec2c81881ff1c0701617bc57f
tree6adfcbf10ddc0c7f51d1ef3a60eb11e647cec78e
parent4d98970e995ce6937ed0fddd4072a56c2f9b5aba
be2net: Revert "make the RX_FILTER command asynchronous" commit

The be_cmd_rx_filter() routine sends a non-embedded cmd to the FW and used
a pre-allocated dma memory to hold the cmd payload. This worked fine when
this cmd was synchronous. This cmd was changed to asynchronous mode by the
commit c4bf40445("make the RX_FILTER command asynchronous"). So now when
there are two quick invocations of this cmd, the 2nd request may end up
overwriting the first request, causing FW cmd corruption.

This patch reverts the offending commit and hence fixes the regression.

Fixes: c4bf40445("be2net: make the RX_FILTER command asynchronous")
Signed-off-by: Sathya Perla <sathya.perla@avagotech.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/emulex/benet/be_cmds.c