]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "net: caif: replace BUG_ON with recovery code"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:56:45 +0000 (13:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 15:30:39 +0000 (17:30 +0200)
commit7fe515c454b18b1ca93d5eaa9b96506179ab5757
tree4a739ed2667dac24c1aba3346199ab4ee2a1e165
parent4920b9fe7664ff52b8281e190f70b7e0a911011b
Revert "net: caif: replace BUG_ON with recovery code"

This reverts commit e5932460734032f6e47d9480c5d27c2d392fda8b.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original change here was pointless as dev can never be NULL in this
function so the claim in the changelog that this "fixes" anything is
incorrect (also the developer forgot about panic_on_warn).  A follow-up
change will resolve this issue properly.

Cc: Aditya Pakki <pakki001@umn.edu>
Cc: David S. Miller <davem@davemloft.net>
Link: https://lore.kernel.org/r/20210503115736.2104747-19-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/caif/caif_serial.c