]> git.baikalelectronics.ru Git - kernel.git/commit
mtd: fix broken state in CFI driver caused by FL_SHUTDOWN
authorAlexey Korolev <akorolev@infradead.org>
Fri, 4 Apr 2008 21:30:01 +0000 (14:30 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 4 Apr 2008 21:46:26 +0000 (14:46 -0700)
commit7faeb30390f14c3a1e15c624a3ef7ca28c70b3a2
treead416f53e71a9f00d7dc4bcf0a24d035cb89ad1f
parent79bfada18fbe36d549c25252440e8f072d791eb5
mtd: fix broken state in CFI driver caused by FL_SHUTDOWN

THe CFI driver in 2.6.24 kernel is broken.  Not so intensive read/write
operations cause incomplete writes which lead to kernel panics in JFFS2.

We investigated the issue - it is caused by bug in FL_SHUTDOWN parsing code.
Sometimes chip returns -EIO as if it is in FL_SHUTDOWN state when it should
wait in FL_PONT (error in order of conditions).

The following patch fixes the bug in state parsing code of CFI.  Also I've
added comments to notify developers if they want to add new case in future.

Signed-off-by: Alexey Korolev <akorolev@infradead.org>
Reviewed-by: Joern Engel <joern@logfs.org>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/mtd/chips/cfi_cmdset_0001.c