]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Fix frontbuffer false positve.
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 24 Feb 2015 21:37:54 +0000 (13:37 -0800)
committerJani Nikula <jani.nikula@intel.com>
Wed, 25 Feb 2015 08:08:15 +0000 (10:08 +0200)
commit7dedfd4428485bf2faa0f4248670df41df188660
tree2b7df3c8a1898cf5723cad5ea45077a927563a64
parent418353ad411175cdd87f88ee7c6280af6f3e9f4f
drm/i915: Fix frontbuffer false positve.

This return 0 without setting atomic bits on fb == crtc->cursor->fb
where causing frontbuffer false positives.

According to Daniel:

The original regression seems to have been introduced in the original
check/commit split:

commit 84e23ce6b0c6857fcdb607d8b656226302f3962e
Author: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Date:   Wed Sep 24 14:20:24 2014 -0300

    drm/i915: move check of intel_crtc_cursor_set_obj() out

Which already cause other trouble, resulting in the check getting moved in

commit fe291b31b337ebd486ae3a9cc3c030e734b3ce95
Author: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Date:   Wed Sep 24 14:20:25 2014 -0300

    drm/i915: Fix not checking cursor and object sizes

The frontbuffer tracking itself only was broken when we shifted it into
the check/commit logic with:

commit 608da2b5fd06f550ee418af1820f6fa998ec4e96
Author: Matt Roper <matthew.d.roper@intel.com>
Date:   Wed Dec 24 07:59:06 2014 -0800

    drm/i915: Refactor work that can sleep out of commit (v7)

v2: When putting more debug prints I notice the solution was simpler
than I thought. AMS design is solid, just this return was wrong.
Sorry for the noise.

v3: Remove the entire chunck that would probably
    be removed by gcc anyway. (by Daniel)

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_display.c