]> git.baikalelectronics.ru Git - kernel.git/commit
ACPI / hotplug / PCI: Fix reference count leak in enable_slot()
authorFeilong Lin <linfeilong@huawei.com>
Thu, 25 Mar 2021 07:26:00 +0000 (15:26 +0800)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 8 Apr 2021 16:04:18 +0000 (11:04 -0500)
commit7ddecc36d8e1c56bb3894403378413e0b4af210c
tree03af689dc7b579d5c2b234e5ff88e5faccbea4f7
parent1b8bd930b05ba1f659bccfc6ef406e93916f57ed
ACPI / hotplug / PCI: Fix reference count leak in enable_slot()

In enable_slot(), if pci_get_slot() returns NULL, we clear the SLOT_ENABLED
flag. When pci_get_slot() finds a device, it increments the device's
reference count.  In this case, we did not call pci_dev_put() to decrement
the reference count, so the memory of the device (struct pci_dev type) will
eventually leak.

Call pci_dev_put() to decrement its reference count when pci_get_slot()
returns a PCI device.

Link: https://lore.kernel.org/r/b411af88-5049-a1c6-83ac-d104a1f429be@huawei.com
Signed-off-by: Feilong Lin <linfeilong@huawei.com>
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/pci/hotplug/acpiphp_glue.c