]> git.baikalelectronics.ru Git - kernel.git/commit
mips: bpf: fix encoding bug for mm_srlv32_op
authorJiong Wang <jiong.wang@netronome.com>
Mon, 3 Dec 2018 22:27:54 +0000 (17:27 -0500)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 7 Dec 2018 21:29:48 +0000 (13:29 -0800)
commit7c99e87c0ce2ae9463d6cb458574d12d86ec642d
treece1e3f37bb27154204a32eada3313a634b334775
parentea7b6a145d03c550b430fded40fab6cd6f927cc4
mips: bpf: fix encoding bug for mm_srlv32_op

For micro-mips, srlv inside POOL32A encoding space should use 0x50
sub-opcode, NOT 0x90.

Some early version ISA doc describes the encoding as 0x90 for both srlv and
srav, this looks to me was a typo. I checked Binutils libopcode
implementation which is using 0x50 for srlv and 0x90 for srav.

v1->v2:
  - Keep mm_srlv32_op sorted by value.

Fixes: 4a9ae7364bc7 ("MIPS: uasm: Add srlv uasm instruction")
Cc: Markos Chandras <markos.chandras@imgtec.com>
Cc: Paul Burton <paul.burton@mips.com>
Cc: linux-mips@vger.kernel.org
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
arch/mips/include/uapi/asm/inst.h