]> git.baikalelectronics.ru Git - kernel.git/commit
misc: tifm: fix possible memory leak in tifm_7xx1_switch_media()
authorruanjinjie <ruanjinjie@huawei.com>
Thu, 17 Nov 2022 06:47:25 +0000 (14:47 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:41:24 +0000 (11:41 +0100)
commit7c5b698b9aa687b40ea43b6aacb6a5ad46376587
treeb69868b15c501195f2bc7d86cd47b20ab1b3255e
parent1ccb34bdcc481657a277511e809f9b51f00dd4c2
misc: tifm: fix possible memory leak in tifm_7xx1_switch_media()

[ Upstream commit fd2c930cf6a5b9176382c15f9acb1996e76e25ad ]

If device_register() returns error in tifm_7xx1_switch_media(),
name of kobject which is allocated in dev_set_name() called in device_add()
is leaked.

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.

Fixes: ea22e13d1b42 ("tifm: move common device management tasks from tifm_7xx1 to tifm_core")
Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20221117064725.3478402-1-ruanjinjie@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/misc/tifm_7xx1.c