]> git.baikalelectronics.ru Git - kernel.git/commit
iwlwifi: mvm: Use div_s64 instead of do_div in iwl_mvm_ftm_rtt_smoothing()
authorNathan Chancellor <nathan@kernel.org>
Mon, 27 Dec 2021 19:17:57 +0000 (12:17 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 10 Jan 2022 00:25:53 +0000 (16:25 -0800)
commit7c3816e9aaf3b4c45013e7c405567e35267c162a
tree322ca1a5bce2ffd4221194776f68200bfedf7e78
parent0ebce2786a7c37b9b6f22e20779e479608c21156
iwlwifi: mvm: Use div_s64 instead of do_div in iwl_mvm_ftm_rtt_smoothing()

When building ARCH=arm allmodconfig:

drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c: In function ‘iwl_mvm_ftm_rtt_smoothing’:
./include/asm-generic/div64.h:222:35: error: comparison of distinct pointer types lacks a cast [-Werror]
  222 |         (void)(((typeof((n)) *)0) == ((uint64_t *)0));  \
      |                                   ^~
drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c:1070:9: note: in expansion of macro ‘do_div’
 1070 |         do_div(rtt_avg, 100);
      |         ^~~~~~

do_div() has to be used with an unsigned 64-bit integer dividend but
rtt_avg is a signed 64-bit integer.

div_s64() expects a signed 64-bit integer dividend and signed 32-bit
divisor, which fits this scenario, so use that function here to fix the
warning.

Fixes: f792be4c5746 ("iwlwifi: mvm: fix 32-bit build in FTM")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20211227191757.2354329-1-nathan@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c