]> git.baikalelectronics.ru Git - kernel.git/commit
atm: nicstar: Fix possible use-after-free in nicstar_cleanup()
authorZou Wei <zou_wei@huawei.com>
Wed, 12 May 2021 07:00:24 +0000 (15:00 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 May 2021 21:03:54 +0000 (14:03 -0700)
commit7c35b3f5e2a0f98dfd0ec9468f85247ca6f01bad
tree260a3101efb4dc949cbb23e1492062283be14e0c
parentbd2fd5c845f6c15182d449a0c30c8ab1c55b6b09
atm: nicstar: Fix possible use-after-free in nicstar_cleanup()

This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.

Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/nicstar.c