]> git.baikalelectronics.ru Git - kernel.git/commit
i40e: Revert "i40e: don't report link up for a VF who hasn't enabled queues"
authorAleksandr Loktionov <aleksandr.loktionov@intel.com>
Sat, 23 Jan 2021 00:22:23 +0000 (00:22 +0000)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 1 Feb 2021 21:18:31 +0000 (13:18 -0800)
commit7befabdabf9f718a112be83e33ab5535a639c180
tree79ab73fc6ed1264b313405df12fcb1f751c6654b
parentfee549fff0874d10752805a991933d2b8ec46241
i40e: Revert "i40e: don't report link up for a VF who hasn't enabled queues"

This reverts commit 346f948a53857560083cdbdd00a96a8ffee81944

VF queues were not brought up when PF was brought up after being
downed if the VF driver disabled VFs queues during PF down.
This could happen in some older or external VF driver implementations.
The problem was that PF driver used vf->queues_enabled as a condition
to decide what link-state it would send out which caused the issue.

Remove the check for vf->queues_enabled in the VF link notify.
Now VF will always be notified of the current link status.
Also remove the queues_enabled member from i40e_vf structure as it is
not used anymore. Otherwise VNF implementation was broken and caused
a link flap.

The original commit was a workaround to avoid breaking existing VFs though
it's really a fault of the VF code not the PF. The commit should be safe to
revert as all of the VFs we know of have been fixed. Also, since we now
know there is a related bug in the workaround, removing it is preferred.

Fixes: 346f948a5385 ("i40e: don't report link up for a VF who hasn't enabled")
Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h