]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-main.c"
authorJakub Kicinski <kuba@kernel.org>
Mon, 20 Jun 2022 19:12:37 +0000 (12:12 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 22 Jun 2022 12:15:49 +0000 (13:15 +0100)
commit7bbf9b1f5ca489f1607346bd8075a00aa67c2ab4
tree5e293ea84b6dc358799b2f870ff2489fcf9ab47d
parentbde0ecd342f1aaab19244711f38e8f1181d0d6de
Revert "drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-main.c"

This reverts commit 608249e205ce74071bdd564867c4fd7f067448c4.

BAR0 is the main (only?) register bank for this device. We most
obviously can't unmap it before the netdev is unregistered.
This was pointed out in review but the patch got reposted and
merged, anyway.

The author of the patch was only testing it with a QEMU model,
which I presume does not emulate enough for the netdev to be brought
up (author's replies are not visible in lore because they kept sending
their emails in HTML).

Link: https://lore.kernel.org/all/20220616085059.680dc215@kernel.org/
Fixes: 608249e205ce ("drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-main.c")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/neterion/vxge/vxge-main.c