]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/perf: remove generated code
authorLionel Landwerlin <lionel.g.landwerlin@intel.com>
Tue, 17 Mar 2020 13:22:20 +0000 (15:22 +0200)
committerLionel Landwerlin <lionel.g.landwerlin@intel.com>
Tue, 17 Mar 2020 13:27:50 +0000 (15:27 +0200)
commit7b7074cf82e9f5f9f70f6da71e75afd6e95ccf47
tree6f3d87336ba6cd044d2e8f5adfb0f0d8789161d4
parent33f1a00b9967c6c43755d94b3202a1d370afe343
drm/i915/perf: remove generated code

A little bit of history :

   Back when i915-perf was introduced (4.13), there was no way to
   dynamically add new OA configurations to i915. Only the generated
   configs baked in at build time were allowed.

   It quickly became obvious that we would need to allow applications
   to upload their own configurations, for instance to be able to test
   new ones, and so by the next stable version (4.14) we added uAPIs
   to allow uploading new configurations.

   When adding that capability, we took the opportunity to remove most
   HW configurations except the TestOa one which is a configuration
   IGT would rely on to verify that the HW is outputting correct
   values. At the time it made sense to have that confiuration in at
   the same time a given HW platform added to the i915-perf driver.

Now that IGT has become the reference point for HW configurations (see
commit 53f8f541ca ("lib: Add i915_perf library"), previously this was
located in the GPUTop repository), the need for having those
configurations in i915-perf is gone.

On the Mesa side, we haven't relied on this test configuration for a
while. The MDAPI library always required 4.14 feature level and always
loaded its configuration into i915.

I'm sure nobody will miss this generated stuff in i915 :)

v2: Fix selftests by creating an empty config

v3: Fix unlocking on allocation error (Dan Carpenter)

v4: Fixup checkpatch warnings

v5: Fix incorrect unlock in error path (Umesh)

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200317132222.2638719-1-lionel.g.landwerlin@intel.com
34 files changed:
drivers/gpu/drm/i915/Makefile
drivers/gpu/drm/i915/i915_perf.c
drivers/gpu/drm/i915/i915_perf_types.h
drivers/gpu/drm/i915/oa/i915_oa_bdw.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_bdw.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_bxt.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_bxt.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_cflgt2.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_cflgt2.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_cflgt3.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_cflgt3.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_chv.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_chv.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_cnl.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_cnl.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_glk.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_glk.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_hsw.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_hsw.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_icl.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_icl.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_kblgt2.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_kblgt2.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_kblgt3.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_kblgt3.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_sklgt2.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_sklgt2.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_sklgt3.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_sklgt3.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_sklgt4.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_sklgt4.h [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_tgl.c [deleted file]
drivers/gpu/drm/i915/oa/i915_oa_tgl.h [deleted file]
drivers/gpu/drm/i915/selftests/i915_perf.c