]> git.baikalelectronics.ru Git - kernel.git/commit
soc: qcom: rpmh-rsc: Don't use ktime for timeout in write_tcs_reg_sync()
authorDouglas Anderson <dianders@chromium.org>
Thu, 28 May 2020 14:48:34 +0000 (07:48 -0700)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 24 Jun 2020 22:41:32 +0000 (15:41 -0700)
commit7b2e9db93e133a04fc6d794250fe6eac1cb1e488
tree62dd14adc92dc5e28929169201a5be3cb1b17aeb
parent6cd86f14e33244c52e74fb6556638818f28502db
soc: qcom: rpmh-rsc: Don't use ktime for timeout in write_tcs_reg_sync()

The write_tcs_reg_sync() may be called after timekeeping is suspended
so it's not OK to use ktime.  The readl_poll_timeout_atomic() macro
implicitly uses ktime.  This was causing a warning at suspend time.

Change to just loop 1000000 times with a delay of 1 us between loops.
This may give a timeout of more than 1 second but never less and is
safe even if timekeeping is suspended.

NOTE: I don't have any actual evidence that we need to loop here.
It's possibly that all we really need to do is just read the value
back to ensure that the pipes are cleaned and the looping/comparing is
totally not needed.  I never saw the loop being needed in my tests.
However, the loop shouldn't hurt.

Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Reviewed-by: Maulik Shah <mkshah@codeaurora.org>
Fixes: 36065c47dd89 ("soc: qcom: rpmh-rsc: Timeout after 1 second in write_tcs_reg_sync()")
Reported-by: Maulik Shah <mkshah@codeaurora.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20200528074530.1.Ib86e5b406fe7d16575ae1bb276d650faa144b63c@changeid
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/soc/qcom/rpmh-rsc.c