]> git.baikalelectronics.ru Git - kernel.git/commit
{nl,mac}80211: allow 4addr AP operation on crypto controlled devices
authorManikanta Pubbisetty <mpubbise@codeaurora.org>
Wed, 8 May 2019 09:25:33 +0000 (14:55 +0530)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 24 May 2019 09:26:54 +0000 (11:26 +0200)
commit7a8bdb6caa1c9e51a08f83165dd6ff1ac5d0dd07
tree1895ee58c3d690975e2125aba14577d574ba5ba3
parent3c230786fee006f1c38bfef4299b9b0bc0e10399
{nl,mac}80211: allow 4addr AP operation on crypto controlled devices

As per the current design, in the case of sw crypto controlled devices,
it is the device which advertises the support for AP/VLAN iftype based
on it's ability to tranmsit packets encrypted in software
(In VLAN functionality, group traffic generated for a specific
VLAN group is always encrypted in software). Commit 7dcff8ac8291
("mac80211: allow AP_VLAN operation on crypto controlled devices")
has introduced this change.

Since 4addr AP operation also uses AP/VLAN iftype, this conditional
way of advertising AP/VLAN support has broken 4addr AP mode operation on
crypto controlled devices which do not support VLAN functionality.

In the case of ath10k driver, not all firmwares have support for VLAN
functionality but all can support 4addr AP operation. Because AP/VLAN
support is not advertised for these devices, 4addr AP operations are
also blocked.

Fix this by allowing 4addr operation on devices which do not support
AP/VLAN iftype but can support 4addr AP operation (decision is based on
the wiphy flag WIPHY_FLAG_4ADDR_AP).

Cc: stable@vger.kernel.org
Fixes: 7dcff8ac8291 ("mac80211: allow AP_VLAN operation on crypto controlled devices")
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
include/net/cfg80211.h
net/mac80211/util.c
net/wireless/core.c
net/wireless/nl80211.c