]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "nouveau/bios: Fix tracking of BIOS image data"
authorLinus Torvalds <torvalds@linux-foundation.org>
Wed, 4 Apr 2012 15:16:25 +0000 (08:16 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 4 Apr 2012 15:16:25 +0000 (08:16 -0700)
commit7a78c316398cd9e610b9bafc30b10f177ae07275
tree1fafcb0f15ac4c6d964aa9b8e70527ac479df624
parent37665d148c4494ac482eea2cc6ad59b903731b42
Revert "nouveau/bios: Fix tracking of BIOS image data"

This reverts commit 1d6a2711d19761d88eff0ebbe7cc30ada7bb7853.

It turns out to trigger the "BUG_ON(!PageCompound(page))" in kfree(),
apparently because the code ends up trying to free somethng that was
never kmalloced in the first place.

BenH points out that the patch was untested and wasn't meant to go into
the upstream kernel that quickly in the first place.

Backtrace:
  bios_shadow
  bios_shadow_prom
  nv_mask
  init_io
  bios_shadow
  nouveau_bios_init
  NVReadVgaCrtc
  NVSetOwner
  nouveau_card_init
  nouveau_load

Reported-by: Meelis Roos <mroos@linux.ee>
Requested-by: Dave Airlie <airlied@gmail.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/gpu/drm/nouveau/nouveau_bios.c