]> git.baikalelectronics.ru Git - kernel.git/commit
reset: fix shared reset triggered_count decrement on error
authorJerome Brunet <jbrunet@baylibre.com>
Wed, 15 Feb 2017 18:15:51 +0000 (19:15 +0100)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Fri, 17 Feb 2017 07:11:47 +0000 (08:11 +0100)
commit7a0ef89c2a9e005146c582580b7d208380cc1402
tree93610a81eede4f90e8232122010f1a4241be4368
parent8910d3073683e1a698dc9e02fca852eb33d353e1
reset: fix shared reset triggered_count decrement on error

For a shared reset, when the reset is successful, the triggered_count is
incremented when trying to call the reset callback, so that another device
sharing the same reset line won't trigger it again. If the reset has not
been triggered successfully, the trigger_count should be decremented.

The code does the opposite, and decrements the trigger_count on success.
As a consequence, another device sharing the reset will be able to trigger
it again.

Fixed be removing negation in from of the error code of the reset function.

Fixes: e0eb222c34a3 ("reset: allow using reset_control_reset with shared reset")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
drivers/reset/core.c