]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: fix memory corruption with GM965 and >4GB RAM
authorJan Niehusmann <jan@gondor.com>
Tue, 1 Mar 2011 22:24:16 +0000 (23:24 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 1 Mar 2011 23:18:44 +0000 (23:18 +0000)
commit7956d2d5f909ff135676d585d478e3f656bd8495
tree188a4118f0df3d92200f02678b4458c645476ed7
parent4f48f6713b368fc7ff1ed25bbd9a706869095b42
drm/i915: fix memory corruption with GM965 and >4GB RAM

On a Thinkpad x61s, I noticed some memory corruption when
plugging/unplugging the external VGA connection. The symptoms are that
4 bytes at the beginning of a page get overwritten by zeroes.
The address of the corruption varies when rebooting the machine, but
stays constant while it's running (so it's possible to repeatedly write
some data and then corrupt it again by plugging the cable).

Further investigation revealed that the corrupted address is
(dev_priv->status_page_dmah->busaddr & 0xffffffff), ie. the beginning of
the hardware status page of the i965 graphics card, cut to 32 bits.

So it seems that for some memory access, the hardware uses only 32 bit
addressing. If the hardware status page is located >4GB, this
corrupts unrelated memory.

Signed-off-by: Jan Niehusmann <jan@gondor.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: stable@kernel.org
drivers/gpu/drm/i915/i915_dma.c