]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: SOF: Intel: hda: fix MSI handling
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 6 Aug 2019 17:06:03 +0000 (12:06 -0500)
committerMark Brown <broonie@kernel.org>
Wed, 7 Aug 2019 13:19:32 +0000 (14:19 +0100)
commit792855c7f8913afa9f1345f9741c848c6cbc4023
tree4134d85c0974357f93188ea48a111b2590f86e90
parent17415e809e410b3f4f29c48069ff2e2b90b2d6d0
ASoC: SOF: Intel: hda: fix MSI handling

The addition of a kernel module parameter to optionally disable MSI
had the side effect of permanently disabling it.

The return value of pci_alloc_irq_vectors() is the number of allocated
vectors or a negative number on error, so testing with the ! operator
is not quite right. It was one optimization too far.

Restore previous behavior to use MSI by default, unless the user
selects not to do so or the allocation of irq_vectors fails.

Fixes: c6bbd95a8632e ('ASoC: SOF: Intel: hda: add a parameter to disable MSI')
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20190806170603.10815-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda.c