]> git.baikalelectronics.ru Git - kernel.git/commit
drm/msm: dpu: Remove crtc_lock from setup_mixers
authorSean Paul <seanpaul@chromium.org>
Fri, 16 Nov 2018 18:42:28 +0000 (13:42 -0500)
committerRob Clark <robdclark@gmail.com>
Tue, 11 Dec 2018 18:10:13 +0000 (13:10 -0500)
commit791972bbe0da38c3ff60e28d44a6b9b31be9f937
tree12cbae6878e4bf7952a06ee8cecacd23d368b35c
parent17cd067943b33025a4cdf675e97d5950e7f0962a
drm/msm: dpu: Remove crtc_lock from setup_mixers

I think the intention here was to protect the enc->crtc access, but
that's insufficient to avoid enc->crtc changing. Fortunately we're
already holding the modeset lock when this is called (from
atomic_check), so remove the crtc_lock and add a modeset lock check.

While we're at it, use the encoder mask from crtc state instead of
legacy pointer.

Changes in v2:
- None

Reviewed-by: Jeykumar Sankaran <jsanka@codeaurora.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c