]> git.baikalelectronics.ru Git - kernel.git/commit
ip: zero sockaddr returned on error queue
authorWillem de Bruijn <willemb@google.com>
Thu, 15 Jan 2015 18:18:40 +0000 (13:18 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 16 Jan 2015 00:41:16 +0000 (19:41 -0500)
commit78b7f7483408867453c8d038593164e1c2cd9a3b
tree9be0fd580d75289fec240cae10ab8ffcc6c85ed2
parentc45d077a00f4fee2c1da16b016018c69e24433b7
ip: zero sockaddr returned on error queue

The sockaddr is returned in IP(V6)_RECVERR as part of errhdr. That
structure is defined and allocated on the stack as

    struct {
            struct sock_extended_err ee;
            struct sockaddr_in(6)    offender;
    } errhdr;

The second part is only initialized for certain SO_EE_ORIGIN values.
Always initialize it completely.

An MTU exceeded error on a SOCK_RAW/IPPROTO_RAW is one example that
would return uninitialized bytes.

Signed-off-by: Willem de Bruijn <willemb@google.com>
----

Also verified that there is no padding between errhdr.ee and
errhdr.offender that could leak additional kernel data.
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_sockglue.c
net/ipv6/datagram.c