]> git.baikalelectronics.ru Git - kernel.git/commit
drm/atomic: fix an error code in mode_fixup()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 7 Feb 2017 23:46:01 +0000 (02:46 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 8 Feb 2017 15:15:42 +0000 (16:15 +0100)
commit77fac04cafe8a61ddd3261bc5f9e8b2b1e9fbd6e
tree097e219297aec6cc2bff67c48e1ce956d88fcaa9
parentd160db17ef81b85c2653c3cc566c9480b3402be8
drm/atomic: fix an error code in mode_fixup()

Having "ret" be a bool type works for everything except
ret = funcs->atomic_check().  The other functions all return zero on
error but ->atomic_check() returns negative error codes.  We want to
propagate the error code but instead we return 1.

I found this bug with static analysis and I don't know if it affects
run time.

Fixes: 3fd24a8ab259 ("drm/atomic: Add ->atomic_check() to encoder helpers")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20170207234601.GA23981@mwanda
drivers/gpu/drm/drm_atomic_helper.c