]> git.baikalelectronics.ru Git - kernel.git/commit
nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
authorMartin Faltesek <mfaltesek@google.com>
Tue, 7 Jun 2022 02:57:27 +0000 (21:57 -0500)
committerJakub Kicinski <kuba@kernel.org>
Wed, 8 Jun 2022 17:17:17 +0000 (10:17 -0700)
commit77e5fe8f176a525523ae091d6fd0fbb8834c156d
tree12f7aab6168bf7878f76c717d2484a3a7301acfb
parent653926f6938d0dbfa44ee66c3d3cf0df3c08b583
nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION

The first validation check for EVT_TRANSACTION has two different checks
tied together with logical AND. One is a check for minimum packet length,
and the other is for a valid aid_tag. If either condition is true (fails),
then an error should be triggered.  The fix is to change && to ||.

Fixes: 26fc6c7f02cb ("NFC: st21nfca: Add HCI transaction event support")
Cc: stable@vger.kernel.org
Signed-off-by: Martin Faltesek <mfaltesek@google.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/st21nfca/se.c