]> git.baikalelectronics.ru Git - kernel.git/commit
tty: fix tty_port_block_til_ready waiting
authorJiri Slaby <jirislaby@gmail.com>
Wed, 24 Jun 2009 17:35:05 +0000 (18:35 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 24 Jun 2009 16:55:50 +0000 (09:55 -0700)
commit777c6599a5f574ca3ea74a4148b80b8918546850
tree43fbe1b0823392eda912b76bc3f180e651f47d6c
parentef7794f2ba2e7ef50199fe6b1b263dbecb119326
tty: fix tty_port_block_til_ready waiting

Since commit 1f62c109f31f2f6165ecad0c7b3d72b34166c7a2 ("tty: use
prepare/finish_wait"), tty_port_block_til_ready() is using
prepare_to_wait()/finish_wait().  Those functions require that the
wait_queue_t be initialised with .func=autoremove_wake_function, via
DEFINE_WAIT().

But the conversion from DECLARE_WAITQUEUE() to DEFINE_WAIT() was not made,
so this code will oops in finish_wait().

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/tty_port.c