]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL...
authorHangbin Liu <liuhangbin@gmail.com>
Wed, 5 Jun 2019 04:27:14 +0000 (12:27 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Jun 2019 00:54:46 +0000 (17:54 -0700)
commit76939bc288398c2cd94c4ce6248791bfa923b5a2
treede30ac9a286dc66474dc7dd3ecf62d34d1a47760
parentb378eb0c6f9f06d38eb397b1f1bfc7f9028a1a89
Revert "fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied"

This reverts commit 0ad688c4903bcd771cf900c47f768c18bc6fe876.

Nathan reported the new behaviour breaks Android, as Android just add
new rules and delete old ones.

If we return 0 without adding dup rules, Android will remove the new
added rules and causing system to soft-reboot.

Fixes: 0ad688c4903b ("fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied")
Reported-by: Nathan Chancellor <natechancellor@gmail.com>
Reported-by: Yaro Slav <yaro330@gmail.com>
Reported-by: Maciej Żenczykowski <zenczykowski@gmail.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/fib_rules.c