]> git.baikalelectronics.ru Git - kernel.git/commit
net/mlx5: Add command entry handling completion
authorMoshe Shemesh <moshe@mellanox.com>
Fri, 27 Dec 2019 05:01:53 +0000 (07:01 +0200)
committerSaeed Mahameed <saeedm@mellanox.com>
Sat, 23 May 2020 00:28:34 +0000 (17:28 -0700)
commit765c0d39a720af83e885b48473e47f83ffa2d689
tree6df648de812dc786f0e89dffe5c4c86198e31fae
parent159a12717d7632817df2873aacd6eeb495af2f5f
net/mlx5: Add command entry handling completion

When FW response to commands is very slow and all command entries in
use are waiting for completion we can have a race where commands can get
timeout before they get out of the queue and handled. Timeout
completion on uninitialized command will cause releasing command's
buffers before accessing it for initialization and then we will get NULL
pointer exception while trying access it. It may also cause releasing
buffers of another command since we may have timeout completion before
even allocating entry index for this command.
Add entry handling completion to avoid this race.

Fixes: ffaf2c1a3989 ("mlx5: Add driver for Mellanox Connect-IB adapters")
Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/cmd.c
include/linux/mlx5/driver.h