]> git.baikalelectronics.ru Git - kernel.git/commit
kcsan: Use tracing-safe version of prandom
authorMarco Elver <elver@google.com>
Fri, 21 Aug 2020 12:31:26 +0000 (14:31 +0200)
committerPaul E. McKenney <paulmck@kernel.org>
Mon, 31 Aug 2020 04:50:13 +0000 (21:50 -0700)
commit765c0628926340eb298f99db648a755d92604ff2
tree7c25a85aad1f29981cd7bddf49039f9e79e66e13
parent3b19e3d42798bc6b4107fb74578796d5fca33b8d
kcsan: Use tracing-safe version of prandom

In the core runtime, we must minimize any calls to external library
functions to avoid any kind of recursion. This can happen even though
instrumentation is disabled for called functions, but tracing is
enabled.

Most recently, prandom_u32() added a tracepoint, which can cause
problems for KCSAN even if the rcuidle variant is used. For example:
kcsan -> prandom_u32() -> trace_prandom_u32_rcuidle ->
srcu_read_lock_notrace -> __srcu_read_lock -> kcsan ...

While we could disable KCSAN in kcsan_setup_watchpoint(), this does not
solve other unexpected behaviour we may get due recursing into functions
that may not be tolerant to such recursion:
__srcu_read_lock -> kcsan -> ... -> __srcu_read_lock

Therefore, switch to using prandom_u32_state(), which is uninstrumented,
and does not have a tracepoint.

Link: https://lkml.kernel.org/r/20200821063043.1949509-1-elver@google.com
Link: https://lkml.kernel.org/r/20200820172046.GA177701@elver.google.com
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
kernel/kcsan/core.c