]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: Intel: Fix conflicting pcm dev drvdata on haswell
authorBen Zhang <benzh@chromium.org>
Fri, 8 Jul 2016 01:54:56 +0000 (18:54 -0700)
committerMark Brown <broonie@kernel.org>
Thu, 14 Jul 2016 16:30:03 +0000 (17:30 +0100)
commit75ea733ac9a542d5a18dd6537d24db363248bd3b
tree6656530b5226d5ef8b6bc7101f0cd49321f77ce9
parent37efd6f85a18302abf7115e49821a583dfbcd3d4
ASoC: Intel: Fix conflicting pcm dev drvdata on haswell

soc-core sets the snd_soc_pcm_runtime->dev drvdata to
snd_soc_pcm_runtime in soc_post_component_init, and access
it in places like codec_reg_show.

hsw_pcm_open overwrites the drvdata to point to hsw_pcm_data,
confusing soc-core, and causing crashes when cat
/sys/devices/pci0000:00/INT3438:00/.../System PCM/codec_reg

This patch removes the set in hsw_pcm_open since it's no longer
used. commit b96c8979c1df ("ASoC: Intel: Split hsw_pcm_data for
playback and capture") already removed all calls to
snd_soc_pcm_get_drvdata(rtd).

Signed-off-by: Ben Zhang <benzh@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/haswell/sst-haswell-pcm.c