]> git.baikalelectronics.ru Git - kernel.git/commit
net: caif: use strlcpy() instead of strncpy()
authorXiongfeng Wang <xiongfeng.wang@linaro.org>
Mon, 8 Jan 2018 11:43:00 +0000 (19:43 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Jan 2018 16:52:18 +0000 (11:52 -0500)
commit74d28eb2a8df6b349c21b5033769078ad9b0c4c7
treeedb6546ee6dd724c23e5b4f257e4769cfbc6afe4
parent2c2b0890a2a2d6c60cddb0af62dd19b7ff88d816
net: caif: use strlcpy() instead of strncpy()

gcc-8 reports

net/caif/caif_dev.c: In function 'caif_enroll_dev':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
be truncated copying 15 bytes from a string of length 15
[-Wstringop-truncation]

net/caif/cfctrl.c: In function 'cfctrl_linkup_request':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
be truncated copying 15 bytes from a string of length 15
[-Wstringop-truncation]

net/caif/cfcnfg.c: In function 'caif_connect_client':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
be truncated copying 15 bytes from a string of length 15
[-Wstringop-truncation]

The compiler require that the input param 'len' of strncpy() should be
greater than the length of the src string, so that '\0' is copied as
well. We can just use strlcpy() to avoid this warning.

Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/caif/caif_dev.c
net/caif/cfcnfg.c
net/caif/cfctrl.c