]> git.baikalelectronics.ru Git - kernel.git/commit
drm: review locking for drm_fb_helper_restore_fbdev_mode
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Sun, 20 Jan 2013 16:32:21 +0000 (17:32 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 13 Feb 2013 23:07:50 +0000 (00:07 +0100)
commit74ce30d4e873089ca5b3f1fcc83849728e3177c0
tree429627e96391fd615275c1150d9482651696e623
parent380ef9e82c785bf7b0c740923ac9900420ee6f47
drm: review locking for drm_fb_helper_restore_fbdev_mode

... it's required. Fix up exynos and the cma helper, and add a
corresponding WARN_ON to drm_fb_helper_restore_fbdev_mode.

Note that tegra calls the fbdev cma helper restore function also from
it's driver-load callback. Which is a bit against current practice,
since usually the call is only from ->lastclose, and initial setup is
done by drm_fb_helper_initial_config.

Also add the relevant drm DocBook entry.

v2: Add promised WARN to restore_fbdev_mode.

Reviewed-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_crtc.c
drivers/gpu/drm/drm_fb_cma_helper.c
drivers/gpu/drm/drm_fb_helper.c
drivers/gpu/drm/exynos/exynos_drm_fbdev.c
include/drm/drm_crtc.h