]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Increase poll time for BDW FCLK_DONE
authorMarta Lofstedt <marta.lofstedt@intel.com>
Fri, 8 Sep 2017 13:28:29 +0000 (16:28 +0300)
committerImre Deak <imre.deak@intel.com>
Tue, 12 Sep 2017 09:19:57 +0000 (12:19 +0300)
commit73aefc6cac03e7e25a79d742a6a3e487946f5e43
treebcdb1f12d86c2e582b20ff9add6181190922edc7
parent48f527f1c83313b3b32dddc058ab5c7c1474c696
drm/i915: Increase poll time for BDW FCLK_DONE

During IGT testing it has been shown that the specification
defined polling time of 1 us for FCLK_DONE, is sometimes not
enough. The issue is still reproducible while disabling
C-states through the PM QoS framework and also while disabling
preemtion. From this the most plausible explanation is that the
issue is due to a firmware flaw.
As a workaround, it is better to wait a little bit longer for
the FCLK_DONE to come around, than to leave with an DRM_ERROR
and having FCLK_DONE at a randome time after.
While spinning a list of igt tests prone to reproduce the issue
the FCLK_DONE poll failed at approximately 2% of the invocations
of the bdw_set_cdclk function. The longest poll time during this
testing was measured to ~7us. So, the suggested new poll time of
100us is on the safe side.

v2: Added more documentation about investigations done.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102243
Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20170908132829.6312-1-marta.lofstedt@intel.com
drivers/gpu/drm/i915/intel_cdclk.c