]> git.baikalelectronics.ru Git - kernel.git/commit
USB: adutux: fix use-after-free on disconnect
authorJohan Hovold <johan@kernel.org>
Wed, 25 Sep 2019 09:29:12 +0000 (11:29 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2019 09:02:59 +0000 (11:02 +0200)
commit72e958fc0642848b7a6bad1c02d2a18a4c663e87
tree2b3af409defcaf291d96984a62a58f6d51e6aa7a
parent4d8d029ff8bce1a04f5af446603d4f7f990ff193
USB: adutux: fix use-after-free on disconnect

The driver was clearing its struct usb_device pointer, which it used as
an inverted disconnected flag, before deregistering the character device
and without serialising against racing release().

This could lead to a use-after-free if a racing release() callback
observes the cleared pointer and frees the driver data before
disconnect() is finished with it.

This could also lead to NULL-pointer dereferences in a racing open().

Fixes: e90b5299c1ed ("USB: FIx locks and urb->status in adutux (updated)")
Cc: stable <stable@vger.kernel.org> # 2.6.24
Reported-by: syzbot+0243cb250a51eeefb8cc@syzkaller.appspotmail.com
Tested-by: syzbot+0243cb250a51eeefb8cc@syzkaller.appspotmail.com
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20190925092913.8608-1-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/adutux.c