]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: Correctly lock inode when removing suid and file capabilities
authorJan Kara <jack@suse.cz>
Thu, 21 May 2015 14:05:56 +0000 (16:05 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 23 Jun 2015 22:01:10 +0000 (18:01 -0400)
commit725931b42d3f47933727a8411d805d19d43a0ace
tree747d73350fb02ca51306530630766dd28b8d0548
parentd4abf1d47b4edda99d4cf9949dd4c33fa25316be
xfs: Correctly lock inode when removing suid and file capabilities

Currently XFS calls file_remove_privs() without holding i_mutex. This is
wrong because that function can end up messing with file permissions and
file capabilities stored in xattrs for which we need i_mutex held.

Fix the problem by grabbing iolock exclusively when we will need to
change anything in permissions / xattrs.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/xfs/xfs_file.c