]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "usb: dwc3: meson-g12a: fix shared reset control use"
authorAmjad Ouled-Ameur <aouledameur@baylibre.com>
Thu, 27 Aug 2020 14:48:10 +0000 (16:48 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Sep 2020 14:41:22 +0000 (16:41 +0200)
commit724a3b41fd1edb9c52e0c76476e237f44a104e12
tree6dd2e943e87d058cd889c0aefa2175d282a14d77
parent4c2a8efcbcb6550060cc9ef095f17e770b2f4cf4
Revert "usb: dwc3: meson-g12a: fix shared reset control use"

This reverts commit 8d41a1f17662e9951a187cd1a766f2e36a42d821.

This commit breaks USB on meson-gxl-s905x-libretech-cc. Reverting
the change solves the issue.

In fact, according to the reset framework code, consumers must not use
reset_control_(de)assert() on shared reset lines when reset_control_reset
has been used, and vice-versa.

Moreover, with this commit, usb is not guaranted to be reset since the
reset is likely to be initially deasserted.

Reverting the commit will bring back the suspend warning mentioned in the
commit description. Nevertheless, a warning is much less critical than
breaking dwc3-meson-g12a USB completely. We will address the warning
issue in another way as a 2nd step.

Fixes: 8d41a1f17662 ("usb: dwc3: meson-g12a: fix shared reset control use")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
Reported-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/20200827144810.26657-1-aouledameur@baylibre.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-meson-g12a.c