]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: sound/ppc/snd_ps3.c: fix error return code
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 19 Aug 2012 07:02:59 +0000 (09:02 +0200)
committerTakashi Iwai <tiwai@suse.de>
Mon, 20 Aug 2012 09:01:14 +0000 (11:01 +0200)
commit7211f6e340516ba792343146fa0fa0c0b1391415
tree7c365d40a2ff237c4bbc2288eae3015d910fca31
parent03bb0a65f23f7263bd1a0719e28e60939db4dfd2
ALSA: sound/ppc/snd_ps3.c: fix error return code

Initialize ret before returning on failure, as done elsewhere in the
function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/ppc/snd_ps3.c