]> git.baikalelectronics.ru Git - kernel.git/commit
perf/core: Avoid put_page() when GUP fails
authorGreg Thelen <gthelen@google.com>
Thu, 11 Nov 2021 02:18:14 +0000 (18:18 -0800)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 11 Nov 2021 12:09:34 +0000 (13:09 +0100)
commit71f292581e32ebcda0421bfeafe7f1513ebb7fc7
treeb349726860336a253e7b136e72fc5da581a2fdc5
parent7b014a0105546b79966d97c634032f431c02ca6d
perf/core: Avoid put_page() when GUP fails

PEBS PERF_SAMPLE_PHYS_ADDR events use perf_virt_to_phys() to convert PMU
sampled virtual addresses to physical using get_user_page_fast_only()
and page_to_phys().

Some get_user_page_fast_only() error cases return false, indicating no
page reference, but still initialize the output page pointer with an
unreferenced page. In these error cases perf_virt_to_phys() calls
put_page(). This causes page reference count underflow, which can lead
to unintentional page sharing.

Fix perf_virt_to_phys() to only put_page() if get_user_page_fast_only()
returns a referenced page.

Fixes: 3aa600e960358 ("perf/core, x86: Add PERF_SAMPLE_PHYS_ADDR")
Signed-off-by: Greg Thelen <gthelen@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20211111021814.757086-1-gthelen@google.com
kernel/events/core.c