]> git.baikalelectronics.ru Git - kernel.git/commit
mlxsw: spectrum: Fix incorrect reuse of MID entries
authorIdo Schimmel <idosch@mellanox.com>
Sun, 30 Oct 2016 09:09:22 +0000 (10:09 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 31 Oct 2016 19:34:43 +0000 (15:34 -0400)
commit71d249a8922405d58c30af468cf4bac83ca7cfdf
tree122aab319e53744db8b5b9f2c1f60678b7dadf72
parent315fcb9c6895e02a67c9233dc5bdd9271318d4fb
mlxsw: spectrum: Fix incorrect reuse of MID entries

In the device, a MID entry represents a group of local ports, which can
later be bound to a MDB entry.

The lookup of an existing MID entry is currently done using the provided
MC MAC address and VID, from the Linux bridge. However, this can result
in an incorrect reuse of the same MID index in different VLAN-unaware
bridges (same IP MC group and VID 0).

Fix this by performing the lookup based on FID instead of VID, which is
unique across different bridges.

Fixes: ff14ef22bfb8 ("mlxsw: Adding layer 2 multicast support")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: Elad Raz <eladr@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum.h
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c