]> git.baikalelectronics.ru Git - kernel.git/commit
cpufreq: intel_pstate: Fix invalid EPB setting
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Thu, 31 Oct 2019 19:26:20 +0000 (12:26 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 8 Nov 2019 10:29:58 +0000 (11:29 +0100)
commit714c76c1c1778d691b39ac0acbc24606b7ca8f04
treed5f4e09003c27b0a4a7342b55d64af786570926f
parentdea20a145c2224b9332fd7769bafd2b43a09e027
cpufreq: intel_pstate: Fix invalid EPB setting

The max value of EPB can only be 0x0F. Attempting to set more than that
triggers an "unchecked MSR access error" warning which happens in
intel_pstate_hwp_force_min_perf() called via cpufreq stop_cpu().

However, it is not even necessary to touch the EPB from intel_pstate,
because it is restored on every CPU online by the intel_epb.c code,
so let that code do the right thing and drop the redundant (and
incorrect) EPB update from intel_pstate.

Fixes: 468a368437491 ("cpufreq: intel_pstate: Force HWP min perf before offline")
Reported-by: Qian Cai <cai@lca.pw>
Cc: 5.2+ <stable@vger.kernel.org> # 5.2+
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
[ rjw: Changelog ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/intel_pstate.c