]> git.baikalelectronics.ru Git - kernel.git/commit
media: pxa_camera: Fix check for pdev->dev.of_node
authorNathan Chancellor <natechancellor@gmail.com>
Fri, 21 Sep 2018 10:00:45 +0000 (06:00 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 4 Oct 2018 18:29:14 +0000 (14:29 -0400)
commit7027d9c750eabd4004929fb06116614443b78be5
tree63309764c313556bce441a12898a307f137239bf
parent17a5ad9ad299268481f6e184e7fe8a3c8a59f345
media: pxa_camera: Fix check for pdev->dev.of_node

Clang warns that the address of a pointer will always evaluated as true
in a boolean context.

drivers/media/platform/pxa_camera.c:2400:17: warning: address of
'pdev->dev.of_node' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (&pdev->dev.of_node && !pcdev->pdata) {
             ~~~~~~~~~~^~~~~~~ ~~
1 warning generated.

Judging from the rest of the kernel, it seems like this was an error and
just the value of of_node should be checked rather than the address.

Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/pxa_camera.c