]> git.baikalelectronics.ru Git - kernel.git/commit
net/sched: sch_taprio: ensure to reset/destroy all child qdiscs
authorDavide Caratti <dcaratti@redhat.com>
Thu, 17 Dec 2020 21:29:46 +0000 (22:29 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 19 Dec 2020 00:43:29 +0000 (16:43 -0800)
commit6fdd2ae14b3e40db659820c31eedcf3820c5aef3
treee09d0bd19ee78c881cfffa08118898d2692fab3d
parented018146741e9b185fa8a676e9fe892bfbfbdb40
net/sched: sch_taprio: ensure to reset/destroy all child qdiscs

taprio_graft() can insert a NULL element in the array of child qdiscs. As
a consquence, taprio_reset() might not reset child qdiscs completely, and
taprio_destroy() might leak resources. Fix it by ensuring that loops that
iterate over q->qdiscs[] don't end when they find the first NULL item.

Fixes: c70e77c38821 ("net/sched: sch_taprio: reset child qdiscs before freeing them")
Fixes: 55fb5b5af7a0 ("tc: Add support for configuring the taprio scheduler")
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Link: https://lore.kernel.org/r/13edef6778fef03adc751582562fba4a13e06d6a.1608240532.git.dcaratti@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/sch_taprio.c